Open andre-arsenault opened 6 years ago
Hi,
Thanks. We're already aware of that and through adapters (MoPub, AdMob) this already works. You'll see this fixed in the next few versions. Will update this issue accordingly.
Great, thanks!
Two follow-ups:
Hi,
Cheers, looking forward to the update to support different-sized ad areas properly.
Yes, I guess it will.
We've unified the code for direct calls and adapter calls so it should work now.
This issue occurs when using test ads with the default inventory hash of fe96717d9875b9da4339ea5367eff1ec.
Current behaviour
Unless a CGRect whose width and height are exactly 320 and 50 respectively is passed to
[MobFoxAd:init:withFrame]
, the following error will be returned:A CGRect of exactly 320x50 will result in test ads being returned correctly.
Expected behaviour:
The ad request parameters documentation shows that there is a parameter called
adpsace_strict
which is set to0
by default.Test ads should behave as the documentation suggests. If larger dimensions are passed, the service should return any available ads up to and including the given ad size.
Example
Running on an iPhone 7 Plus device with a screen width of 414px, I pass in a rect of 414 width and 50 height to
[MobFoxAd:init:withFrame]
. No ads are returned and the 'no fill' error referenced above is thrown.Instead I would expect at least the default 320x50 test banner ad to be returned, if there are no natively-sized test banners for this device's dimensions.
Also, if a smaller ad is returned, I would expect for it to be centered within the rect specified.