search

mobi-css / mobi.css

A lightweight, scalable, mobile-first CSS framework
http://getmobicss.com/
MIT License
2.34k stars 145 forks source link

Suggest to rename mt-15 and mt-30 #43

Closed J-F-Liu closed 7 years ago

J-F-Liu commented 7 years ago

Use gap, double-gag or small-gap, big-gap. This is easier to understand and consistent with naming style of other class names. Furthermore, the gap height can be changed in variable and not equal to 15px.

xcatliu commented 7 years ago

Your suggestion make sense. Actually we have $width-gap as a variable. User may customize their $width-gap then mt-15 will not be 15px.

xcatliu commented 7 years ago

But gap or double-gap don't mean margin to top, maybe we can use mt-0, mt-gap, mt-double-gap?

Any other ideas?

J-F-Liu commented 7 years ago

How about vertical-gap, vertical-big-gap? margin-top: 0 is the default value and margins are not inherited, so mt-0 is not require.

xcatliu commented 7 years ago

That sounds good :+1:

xcatliu commented 7 years ago

I'm going to rename it to top-gap and top-gap-big duo to following reasons:

  1. top is easily to type than vertical, and more semantic than vertical -- we only set margin-top
  2. It's better to follow this rule: All variables need to be named as ${rule}-${element}-${modifier}, so I put big at end
xcatliu commented 7 years ago

Added top-gap-0