Changes [CHORE] 767 action sheet design changes #767 - Githubissues

mobi / goponents

Angular UI Components for utilization in the Tangoe Platform

http://tangoe.design

MIT License

7 stars 20 forks source link

Changes [CHORE] 767 action sheet design changes #767 #891

Closed adhiyan-tangoe closed 1 year ago

adhiyan-tangoe commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines
[X] Tests for the changes have been added
[X] Docs have been added or updated

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] Style Update (CSS)
[ ] Other... Please describe:

What is the current behavior?

Resolves #767

What is the new behavior?

Handled appearance of scrollbar on accordion's expansion by adjusting the height.
Font style has been changed to Nunito with light weight for the shell area.
Fixed the colour issue for the danger action sheet panel.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

stolve commented 1 year ago

@kpmurphh and myself have no way to provide approval/feedback for this issue. We do not have an instance of goponents on our systems in order to look at the visual fix and we are not in a position to give feedback on coding approaches. Please attach a screenshot of the update or block time on one of our calendars for a review session.