search

mobi / telephone_number

Phone number validation for Ruby
MIT License
388 stars 32 forks source link

Chore: Update MetaData for IVORY COAST #93

Closed hkairi closed 3 years ago

joshwetzel commented 3 years ago

Hello! Thanks for submitting this pull request.

Did you pull these changes directly from our upstream (https://github.com/google/libphonenumber)? If so, were other changes excluded?

hkairi commented 3 years ago

Hello

Did you pull these changes directly from our upstream (https://github.com/google/libphonenumber) -- Yes

I only took changes for IVORY COAST ( country_code="CI" )

joshwetzel commented 3 years ago

Is data/telephone_number_data_file.dat correct? I'm seeing a diff when I generate it using your XML.

hkairi commented 3 years ago

data/telephone_number_data_file.dat is correct. I am using it in my application right now and the validation is working as expected.

joshwetzel commented 3 years ago

Thanks for your patience. We will include these changes as part of a larger metadata update rather than cutting a new release specifically for this. It is something I plan on working on next week.

joshwetzel commented 3 years ago

These updates were included with https://github.com/mobi/telephone_number/pull/95. Thanks again for your patience.