search

mobidata-bw / ipl-orchestration

MobiData-BW Integrationsplattform (IPL), an API platform that provides mobility data for Baden-Württemberg across many domains.
https://api.mobidata-bw.de
European Union Public License 1.2
0 stars 0 forks source link

fixed the formatting of stops sld #103

Closed richardforsterNVBW closed 8 months ago

richardforsterNVBW commented 8 months ago

fixed the formatting of the sld file

hbruch commented 8 months ago

This PR seems to include the changes of #98, also?

richardforsterNVBW commented 8 months ago

Yes. I created a new branch since #98 was already behind. I should have pushed the changes to #98 instead? What is the procedure?

hbruch commented 8 months ago

OK. Could you close #98 then? Another option would have been to rebased #98 on the latest commit on main, and force push the original branch again. And then add the reformat as separate commit. Usually, reformatting and functional changes should go to separate commits, so others can easily follow what changed, but never mind.

richardforsterNVBW commented 8 months ago

I can close it.

For documentation purpose:

We did not use xmllint until now, but to keep a consistent formatting, I suggest to reformat at least this sld with e.g.

xmllint --output mdbw_transit_stops_default.sld --format mdbw_transit_stops_default.sld.

Note to self: For other slds and xml files, we should lint them in an explicit commit and add linting to the github actions.