search

mobie / mobie-utils-python

Python tools for MoBIE
MIT License
9 stars 5 forks source link

missing check, view validation #70

Closed martinschorb closed 2 years ago

martinschorb commented 2 years ago

Hi,

I discovered that the view validation does not check for existence of the colorByColumn column in the linked table.

constantinpape commented 2 years ago

That is on purpose, colorByColumn is optional (and will default to regionId / labelId)

martinschorb commented 2 years ago

maybe I wasn't clear enough: If a colorByColumn is specified in the regionDisplay but it points to a non-existing column in the table (like when you rename the columns to abbreviations 😆, it validates as correct but obviously crashes MoBIE.

constantinpape commented 2 years ago

Ah, that makes sense. I will fix it.

constantinpape commented 2 years ago

Implemented in #68