mobie / mobie-viewer-fiji

BSD 2-Clause "Simplified" License
32 stars 14 forks source link

overlay names for multiple sources is a problem #1013

Open tischi opened 1 year ago

tischi commented 1 year ago

When overlaying names for multiple sources in a grid this essentially does not work:

image

@imagejan Do you maybe have an idea how to conceptually solve this? I will write the code of course ;-)

imagejan commented 1 year ago

Can the 'overlay names' be activated per layer? I guess in most cases the user would know they want to display the "wells" names, for example.

Related: how are the names generated currently? Taken directly from the table? Concatenated from the view name and the source?

tischi commented 1 year ago

Can the 'overlay names' be activated per layer? I guess in most cases the user would know they want to display the "wells" names, for example.

Thanks! That's probably an option....would either to mean another checkbox or we add it to the [ S ] (Settings button UI), for each layer.

Also, maybe for grid views the behaviour could be different than in other cases.

FYI: here is another (beautiful imho) use-case:

image

To still enable this conveniently I think we would need to keep the current "overlay all names" option in addition to providing this for the individual layers?!


Related: how are the names generated currently? Taken directly from the table? Concatenated from the view name and the source?

Depends how the data is opened; I think is too complex to answer simply.

tischi commented 11 months ago

I made a PR: https://github.com/mobie/mobie-viewer-fiji/pull/1063

Improvement ideas:

  1. Draw black background below the texts (implemented in PR via fb9817e)
  2. Collect all the text bounding boxes before drawing them and then only draw texts that do not overlap with any other text (TODO)
tischi commented 11 months ago

I made a PR: https://github.com/mobie/mobie-viewer-fiji/pull/1063

Improvement ideas:

  1. Draw black background below the texts (implemented in PR via fb9817e)
  2. Collect all the text bounding boxes before drawing them and then only draw texts that do not overlap with any other text (TODO)