mobie / mobie-viewer-fiji

BSD 2-Clause "Simplified" License
30 stars 12 forks source link

Change Java3D import #1142

Open tischi opened 4 months ago

tischi commented 4 months ago

So if you change your dependency to org.jogamp.java3d:java3d-core:1.7.2, and change your imports from org.scijava.java3d to org.jogamp.java3d, you can gain the benefits. Fiji will switch to this version "Soon".

@ctrueden If I would do this today, would this would this work within Fiji, or would I need to ship the org.jogamp.java3d:java3d-core:1.7.2 via my update site (since it is not yet in Fiji)?

ctrueden commented 4 months ago

I just made a brief try at updating the 3D Viewer to use the JogAmp Java 3D 1.7.2. I was thinking I could upload the new Java 3D JARs, while leaving the old ones in place as well (different package prefixes, so they do not clash). But I wanted to check whether they were really a drop-in replacement apart from the package prefixes, and what I found is not quite. I pushed a branch with the needed changes, which does not compile due to a couple of differences:

So the short answer is NO, even if we uploaded the new JogAmp Java 3D JARs immediately, I suspect you would run into some compilation errors as well. Did you try it yet? If everything compiles and works for you—or if you have time to quickly fix any problems you encounter—then I'm certainly willing to upload the JogAmp Java 3D JARs to support you, rather than you needing to ship them yourself.

tischi commented 4 months ago

@ctrueden thank you very much for having a look!

I don't understand what I could do now next, because the compilations issues that you describe above appear to be related to upstream code, isn't it?