mobie / mobie-viewer-fiji

BSD 2-Clause "Simplified" License
28 stars 12 forks source link

Manual registration, close original sources #1169

Closed martinschorb closed 1 week ago

martinschorb commented 1 week ago

Hi, could the original moving source be removed when the transformation is accepted? Then the active viewer would immediately show the result and not a duplicated source (original + transformed).

tischi commented 1 week ago

I can easily make the original source invisible. What is a bit more tricky is to fully remove it, because one display settings UI element can correspond to multiple sources (e.g. in a grid view), and then maybe one does not want to remove all of them. But I could check that there in fact is a one-to-one mapping and only then remove it.

martinschorb commented 1 week ago

I guess making it invisible should be sufficient.

tischi commented 1 week ago

Hi @martinschorb,

I uploaded a new version where the non-transformed input sources and their corresponding display UI items should be removed once the transformations are accepted.

Please test it.

martinschorb commented 1 week ago

tested, works!

martinschorb commented 5 days ago

When doing this for BigWarp and choosing multiple moving sources, it closes all but the last saved transformed source. I would expect to keep all transformed moving sources.

martinschorb commented 5 days ago

plus, it also closes the sources when not saving them and clicking Cancel

martinschorb commented 5 days ago

I think it even saves the transformed source view when clicking Cancel in the save view dialog