search

mobie / mobie.github.io

1 stars 3 forks source link

Remote vs. local #36

Closed tischi closed 3 years ago

tischi commented 3 years ago

Right now my code looks like this, only allowing for two image data locations (S3 and FS):

        if ( options.values.getImageDataStorageModality().equals( MoBIEOptions.ImageDataStorageModality.S3 ) ) 
            imageDataLocation = "remote";
        else
            imageDataLocation = "local";

Not sure what to do here...

tischi commented 3 years ago

If we keep this logic, maybe we could rename remote to S3 and local to FS?

constantinpape commented 3 years ago

If we keep this logic, maybe we could rename remote to S3 and local to FS?

Yes, that's a good point. Also if we potentially want to support other object stores like GCS or ABS at some point.

tischi commented 3 years ago

ok, should we change spec? maybe something a bit more readable: s3object, file?

constantinpape commented 3 years ago

ok, should we change spec? maybe something a bit more readable: s3object, file?

Yes, let's do it. I will change it this afternoon.

constantinpape commented 3 years ago

Do you mind if we call it s3store instead? s3object sounds like we are referring to a specific object in the object store.

tischi commented 3 years ago

s3store and fileSystem?

constantinpape commented 3 years ago

Update in the schema, the two projects on git that have branches with the new spec and in the example project.