search

mobie / mobie.github.io

1 stars 3 forks source link

Remove view from source #46

Closed tischi closed 3 years ago

tischi commented 3 years ago

@constantinpape @martinschorb

The discussion about the crop indicated to me that it is confusing to have a "default" view within the source in sources. Would you mind not supporting this anymore and move those views into views.

Several reasons:

  1. Within views one can specify a name that is different to the source name
  2. Maybe sometimes people do not want to have a "default" view on a specific source, but, e.g. only a collection of crops
  3. Conceptually it feels cleaner to fully separate the sources from the views
  4. It would simplify both our spec as well as my code because I don't have to look for the views in two places
constantinpape commented 3 years ago

Yes, I think this makes a lot of sense. I will change it in the spec and the python code and update our example projects.

tischi commented 3 years ago

Thanks! I think this is a conceptually very nice improvement!

constantinpape commented 3 years ago

I changed it in the spec and the python utils. I also made this branch for you to test it: https://github.com/mobie/zebrafish-lm-datasets/pull/3

Let me know when this works in MoBIE, I will merge it into the spec-v2 branch then and update the other datasets.

tischi commented 3 years ago

Works! Thanks!

constantinpape commented 3 years ago

Works! Thanks!

Ok, should I update the other projects?

tischi commented 3 years ago

Yes, please! Also the crop test project on your server please.

constantinpape commented 3 years ago

Ok, I updated it now for all the projects that have a spec-v2 branch:

and for the crop test project.

I think everything is done here, so I am closing the issue. Feel free to reopen if anything still needs to be changed here.