search

mobie / mobie.github.io

1 stars 3 forks source link

Add (optional) description field to view #50

Open constantinpape opened 3 years ago

constantinpape commented 3 years ago

We should add an (optional) field description to view in order to support more detailed information on views, e.g. for figure legends. (Suggested by @tischi in a google doc on MoBIE project ideas.) This is very easy on the spec side, however the question is how to display this in Fiji. I think a good option would be to have it like a tool tip when hovering over the view menu item, but I am not sure if that's feasible in the fiji UI.

tischi commented 3 years ago

In addition to the too tip (which should be possible in Java Swing), I think it would be cool if the view legend was visible within the BDV window. In BDV one can have text overlays. I think having an additional window would create too much clutter...

KateMoreva commented 3 years ago

AbstractSourceDisplay now has a String sourcesDescription that could be filed (from the metadata or maybe we should think about an extra window for that also).

Implemented in: https://github.com/mobie/mobie-viewer-fiji/pull/416

constantinpape commented 3 years ago

AbstractSourceDisplay now has a String sourcesDescription that could be filed

Ok, I think filling the sourcesDescription (shouldn't it be called sourceDescription?) from the description field in the metadata is a good idea. I will create an example for that and post it here once I have it.

constantinpape commented 3 years ago

@KateMoreva I have added a dataset with description for all the sources. You can find it both on the group share or github:

tischi commented 3 years ago

@KateMoreva @constantinpape

I think this issue could be another one with a relatively high priority to work on. What do you think? Personally I feel this could be even more important than the custom grid view.

For instance, imagine people browsing the bookmarks of the platybrowser and we could provide a link to the published figure. I think that'd be quite awesome and useful.

In fact, I found out that one can link to the figures of the Cell publication:

https://www.cell.com/cell/fulltext/S0092-8674(21)00876-X#fig1

We should also think about adding instructions for each source of how to download the full raw data.

KateMoreva commented 3 years ago

@KateMoreva @constantinpape

I think this issue could be another one with a relatively high priority to work on. What do you think? Personally I feel this could be even more important than the custom grid view.

For instance, imagine people browsing the bookmarks of the platybrowser and we could provide a link to the published figure. I think that'd be quite awesome and useful.

In fact, I found out that one can link to the figures of the Cell publication:

https://www.cell.com/cell/fulltext/S0092-8674(21)00876-X#fig1

We should also think about adding instructions for each source of how to download the full raw data.

Work over this issue is in progress, I think by the end of the week it will be fully functional.

constantinpape commented 3 years ago

Just as a side-note, I think the description we are adding here is for sources instead of views. But I think we should just go ahead with this as is and it should be fairly straightforward to implement the same mechanism for views once we have it for sources.

KateMoreva commented 3 years ago

Just as a side-note, I think the description we are adding here is for sources instead of views. But I think we should just go ahead with this as is and it should be fairly straightforward to implement the same mechanism for views once we have it for sources.

@constantinpape, have we got a project with a views description?

constantinpape commented 3 years ago

@constantinpape, have we got a project with a views description?

Not yet, but I will create one.

constantinpape commented 3 years ago

@KateMoreva I added descriptions for all the views in the same dataset as before:

KateMoreva commented 3 years ago

@KateMoreva I added descriptions for all the views in the same dataset as before:

@constantinpape Thank you! Just a small question, at the moment for the views we want to have a simple tooltip with the description or labels over images like in https://www.cell.com/cell/fulltext/S0092-8674(21)00876-X#fig1?

constantinpape commented 3 years ago

Just a small question, at the moment for the views we want to have a simple tooltip with the description

Let's start with tooltips for now and then have a look at it together next week to discuss if we want some more advanced functionality.