search

mobie / mobie.github.io

1 stars 3 forks source link

Clarification of selectedSegmentIds #61

Open K-Meech opened 3 years ago

K-Meech commented 3 years ago

It would be useful to add a bit of clarification as to what a 'segment id' is here: https://github.com/mobie/mobie.github.io/blob/master/schema/view.schema.json#L197

@constantinpape Am I right that it is "sourceName;timePoint;label_id";, like here: https://github.com/mobie/platybrowser-datasets/blob/spec-v2/data/1.0.1/dataset.json#L2927? (I need to update the bookmark saving to reflect this too)

constantinpape commented 3 years ago

@constantinpape Am I right that it is "sourceName;timePoint;label_id";, like here: https://github.com/mobie/platybrowser-datasets/blob/spec-v2/data/1.0.1/dataset.json#L2927? (I need to update the bookmark saving to reflect this too)

Yes, that's correct. Feel free to expand the description string to describe it better.

K-Meech commented 2 years ago

@constantinpape - just wanted to check, what's the format for the selectedAnnotationIds in sourceAnnotationDisplay? https://github.com/mobie/mobie.github.io/blob/master/schema/view.schema.json#L286 Is it sourceName;annotationId? Thanks!

constantinpape commented 2 years ago

@K-Meech it's timePoint;annotationId (which should be added as documentation...)

K-Meech commented 2 years ago

Ok great! I can add lines to the docs for both of these :)