Closed constantinpape closed 2 years ago
For the sources I would suggest we use sources
if we have a List[str]
and nestedSources
if we have a List[List[str]]
.
What do you think @tischi @martinschorb?
I would let @martinschorb decide as he mostly stumbled over this and may have a feel for what would be most intuitive.
For the sources I would suggest we use
sources
if we have aList[str]
andnestedSources
if we have aList[List[str]]
.
agreed.
OK, I can do this.
@constantinpape We have to coordinate this as this will be a breaking change.
OK, I can do this.
@constantinpape We have to coordinate this as this will be a breaking change.
Yep, I am preparing some branches for you to test (was just waiting for the change in the source list names). I will ping you once I have some to test.
Here's the example branch / PR @tischi: https://github.com/mobie/clem-example-project/pull/25
This seems to cover the corresponding changes: https://github.com/mobie/mobie-viewer-fiji/pull/726 @constantinpape could you have a look at the code changes whether you think I covered everything?
I will merge this now, otherwise I can't properly check if updating the projects works correctly. I will let you know somewhere else once all the projects for testing are there.
Addressing the following things:
sourceAnnotationDisplay->regionDisplay
,selctedAnnotationIds->selectedRegionIds
imageDisplay
instead ofimageSourceDisplay
)annotation_id
column to ->region_id
, see https://github.com/mobie/mobie-viewer-fiji/issues/681