mobie / platybrowser-project

7 stars 5 forks source link

adding some new images #97

Open tischi opened 11 months ago

tischi commented 11 months ago

@constantinpape

I would like to add some new images.

I guess I would need to create a new version for this, right?!

I guess this should be a major version bump? Or is this only if there is a new primary data type?

The point here is that we will sequentially add more and more images, I don't think we should always increase the major version, should we?

constantinpape commented 11 months ago

The version logic was the following:

So if we stick to the scheme you would need to to bump the patch version. But from my end it would be fine to just add these to the current version instead; as long as none of the current data is removed or otherwise changed.

constantinpape commented 11 months ago

The script https://github.com/mobie/platybrowser-project/blob/main/update_patch.py is there for bumping patch versions, but it is outdated because it's not compatible with the structure of the project that was updated to the mobie layout. So if you wanted to bump the patch version the script would need to be brought up-to-date.