mobify / commercecloud-ocapi-client

Salesforce Commerce Cloud Open Commerce API (OCAPI) for Node and browsers 🛒
MIT License
70 stars 31 forks source link

Remove babel dependency as recommended in docs, fix audit vulnerabilities #20

Closed olibrook closed 5 years ago

olibrook commented 5 years ago

We were unable to release the Mom's love is like no other version of mobify-platform-sdks on time due to mysterious build failures relating to babel / babel-cli. My understanding is:

  1. babel has been split into babel-core and babel-cli.
  2. babel is deprecated, so users are advised to install the other two.
  3. Both babel and babel-cli install a script at node_modules/.bin/babel. It is not clear which script wins when you mistakenly install both packages.
  4. Under certain circumstances we seem to have the babel package's script installed. As of version 6 , that script throws an error with new installation instructions.

The actual problem deploying was related to our Hybris API, but this package makes the same mistake. This fix is precautionary.