mobify / commercecloud-ocapi-client

Salesforce Commerce Cloud Open Commerce API (OCAPI) for Node and browsers 🛒
MIT License
69 stars 31 forks source link

Update refinement params #28

Closed vcua-mobify closed 4 years ago

vcua-mobify commented 4 years ago

…f OCAPI

Description

From support ticket https://support.mobify.com/a/tickets/5541

This change modifies how refine parameters are set so that it matches the format outlined in https://documentation.b2c.commercecloud.salesforce.com/DOC4/index.jsp?topic=%2Fcom.demandware.dochelp%2FOCAPI%2F16.9%2Fshop%2FResources%2FProductSearch.html

That is: refine_1=, refine_2= rather than just separating with a comma.

Currently, the changes in this PR are applied in several places throughout ProductSearchAPI.js. We might be able to pull some of this into the SDK to avoid repetition.

Type of change

How to test this PR?

The code itself is untested. The changes were tested in Postman to make sure this type of change would work.

Checklist:

drewzboto commented 4 years ago

@vcua-mobify Can we close this in favor on the newly merged #29?

bendvc commented 4 years ago

Hey @vcua-mobify,

Thanks for the PR, we've gone ahead an created an merged a separate PR that fixes this issue here 👉 #29. This PR is similar to a closed PR here.

If you have any questions, feel free to reach out to me.