mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js
60 stars 18 forks source link

TypeError: Cannot read property 'undefined' of undefined #14

Closed marlowpayne closed 10 years ago

marlowpayne commented 10 years ago

Issue when running nightwatch tests using latest master code from nightwatch-commands

Error in terminal reads: TypeError: Cannot read property 'undefined' of undefined at Object. (/Users/Marlow/Development/Mobifyjs-coasthotels-mobile/node_modules/nightwatch-commands/commands/preview.js:32:21) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17) at require (module.js:380:17) at /Users/Marlow/Development/Mobifyjs-coasthotels-mobile/node_modules/nightwatch/lib/core/api.js:247:29 at Array.forEach (native) at loadCustomCommands (/Users/Marlow/Development/Mobifyjs-coasthotels-mobile/node_modules/nightwatch/lib/core/api.js:245:18)

I have performed a workaround by rolling back my local master to before the last PR was merged, and created a new "rollback" branch with which to rollback my nightwatch-commands in my nightwatch tests (inside of package.json: "nightwatch-commands": "git+https://github.com/mobify/nightwatch-commands.git#rollback").

scalvert commented 10 years ago

You need to update your site.json format. I was just in the middle of typing an email to you guys.

[image: Mobify Logo]Steve Calvert, Engineering Manager Mobify – Powering the Adaptive Web mobify.com http://www.mobify.com/ | @mobify http://twitter.com/mobify Passionate about the mobile web? Check out mobifycareers.com

On Mon, Apr 14, 2014 at 2:45 PM, Marlow Payne notifications@github.comwrote:

Issue when running nightwatch tests using latest master code from nightwatch-commands

Error in terminal reads: TypeError: Cannot read property 'undefined' of undefined at Object. (/Users/Marlow/Development/Mobifyjs-coasthotels-mobile/node_modules/nightwatch-commands/commands/preview.js:32:21) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17) at require (module.js:380:17) at /Users/Marlow/Development/Mobifyjs-coasthotels-mobile/node_modules/nightwatch/lib/core/api.js:247:29 at Array.forEach (native) at loadCustomCommands (/Users/Marlow/Development/Mobifyjs-coasthotels-mobile/node_modules/nightwatch/lib/core/api.js:245:18)

I have performed a workaround by rolling back my local master to before the last PR was merged, and created a new "rollback" branch with which to rollback my nightwatch-commands in my nightwatch tests (inside of package.json: "nightwatch-commands": "git+ https://github.com/mobify/nightwatch-commands.git#rollback").

— Reply to this email directly or view it on GitHubhttps://github.com/mobify/nightwatch-commands/issues/14 .

qa-derrick commented 10 years ago

Not a bug, see @scalvert comment above