Update Nightwatch - Githubissues

mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js

60 stars 18 forks source link

Update Nightwatch #29

Closed wizardlyhel closed 10 years ago

wizardlyhel commented 10 years ago

This update will make Nightwatch

download the selenium web driver and the chrome web driver on install
puts the downloaded file in the right place with a generic filename

Note: config.js and install.js is a straight copy from the selenium-standalone npm module

Reviewer: @scalvert

scalvert commented 10 years ago

We should probably delete the README in the selenium directory too, as we're now managing the version number in config.js

scalvert commented 10 years ago

Let's move both config.js and install.js into a subfolder inside the selenium folder.

selenium/installation

This way we won't muddle the rest of nightwatch-commands with selenium stuff.

wizardlyhel commented 10 years ago

@scalvert This merge is ready along with the generators updates.

wizardlyhel commented 10 years ago

Reviewer: @scalvert

scalvert commented 10 years ago

@Helen-Mobify cool! Looks good! I just need to test drive it later and then I'll merge.

scalvert commented 10 years ago

@Helen-Mobify OK I had to make a few changes here to fix the install, as it was failing due to a missing node module. I've updated and tested this, and it all works.

It gets a :+1: from me.