Updating preview command - Githubissues

mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js

60 stars 18 forks source link

Updating preview command #3

Closed scalvert closed 10 years ago

scalvert commented 10 years ago

Adding site URL and bundle URL as querystring parameters so they are input on the server. Helps speed up our tests.

Status: Opened for visibility

Reviewers: @kbingman

Changes

required in querystring module
changed command to skip inputting and waiting for elements present
How to test-drive this PR
open existing project using Nightwatch
delete nightwatch-commands package
npm install
grunt nightwatch
ensure inputs are filled out when preview loads

kbingman commented 10 years ago

Looks good. :+1: