0.4 Nightwatch Compatibility - Githubissues

mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js

60 stars 18 forks source link

0.4 Nightwatch Compatibility #4

Closed kbingman closed 10 years ago

kbingman commented 10 years ago

This adds compatibility for the new 0.4 version of Nightwatch and fixes a few async issues along the way.

Status: Opened for visibility

Reviewers: @scalvert

Changes

Fixes templateName and makes it properly async
Fixes elementsPresent to work with the new syntax
Fixes and updates all tests
How to test-drive this PR
run npm test
go to a project and be sure the package.json points to the branch
be sure that the tests pass

scalvert commented 10 years ago

:+1: