search

mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js
60 stars 18 forks source link

add waitForUrlToContain command #44

Closed ellenmobify closed 8 years ago

ellenmobify commented 8 years ago

Status: Ready for Review Owner: Ellen Reviewers: @RobotRogue @twangtina @gsaray @lilyzh @mobify-derrick @marlowpayne

Changes

qa-derrick commented 8 years ago

Lets add a test for this please

marlowpayne commented 8 years ago

A couple pretty general questions for nightwatch-commands:

qa-derrick commented 8 years ago

@marlowpayne great questions.

  1. Yes you are right, we should be doing that. Going forward we will make sure that happens.
  2. Also a great suggestion, however I think we can create a separate PR specifically for adding linting and bringing the files up to speed.
marlowpayne commented 8 years ago

@mobify-derrick awesome. I totally agree that a separate PR will be needed for linting + other enhancements. Should this PR follow gitflow then? We can add linting and/or other changes into the new release in develop.

Another thing: This repo has some tests written for it + a circle.yml file, but they're broken and CircleCI isn't integrated into PRs. We should probably look into that as an enhancement too.

qa-derrick commented 8 years ago

@marlowpayne you are probably right, @ellenmobify lets get this PR following gitflow.

Ellen and I were discussing the tests, we need to get them working again. We'll probably engage you for next release for some help on them. Tests for assertions work however the commands do not. I would suggest that this is also a separate PR.

For now I am testing this manually

marlowpayne commented 8 years ago

@mobify-derrick all sounds good. I'll also start looking into how easy / painful the catch-up with the eslint standard would be.

marlowpayne commented 8 years ago

Closing this PR so that it can migrate to one for gitflow.