Adjust linting targets to capture more of our source code - Githubissues

mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js

60 stars 18 forks source link

Adjust linting targets to capture more of our source code #48

Closed marlowpayne closed 8 years ago

marlowpayne commented 8 years ago

Status: Ready for Review Owner: @marlowpayne Reviewers: @mobify-derrick @ellenmobify

Changes

Instead of having to whitelist all of our linting targets, let's instead lint all JS and blacklist code that's beyond our source code's scope (selenium installation JS, node modules' JS, etc)
Todos:
[x] +1
Feedback:

none so far

How to Test

Checkout code
npm test
Make a deliberate JS error and make sure the linter catches it

ellenmobify commented 8 years ago

:+1: does exactly as described