mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js
60 stars 18 forks source link

Update readme #50

Closed ellenmobify closed 8 years ago

ellenmobify commented 8 years ago

Status: Ready for Review Owner: Ellen Reviewers: @marlowpayne @RobotRogue @twangtina @gsaray @lilyzh @mobify-derrick

Changes

qa-derrick commented 8 years ago

@ellenmobify This is great so far. Given that GH released issue and pull request templates, I would like them to be added.

https://github.com/blog/2111-issue-and-pull-request-templates

Let's get some initial ones in and we can iterate on them.

qa-derrick commented 8 years ago

Once we merge this, I'll set up protected branches for the repo

qa-derrick commented 8 years ago

:+1: I think this ready to go. @marlowpayne any additional comments?

marlowpayne commented 8 years ago

This looks solid. :+1: nice work, @ellenmobify :shipit: