Bugfix for waitForAjaxCompleted - Githubissues

mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js

60 stars 18 forks source link

Bugfix for waitForAjaxCompleted #61

Closed ellenmobify closed 8 years ago

ellenmobify commented 8 years ago

Status: Ready for Review or Open for Visibility Owner: @ellenmobify Reviewers: @marlowpayne @mikenikles

Changes

Fixes a bug in waitForAjaxCompleted which would fail if $ was not bound to jQuery
Todos:
[x] Passed linting check (run grunt lint)
[x] Updated README
[x] Updated CHANGELOG
Feedback:

none so far

How To Test

Checkout this branch
npm install
npm link
grunt lint
Test on projects like https://github.com/mobify/garnet-hill-mobile

marlowpayne commented 8 years ago

👍