mobify / nightwatch-commands

A set of Mobify specific custom commands for Nightwatch.js
60 stars 18 forks source link

Documentation at .waitForCondition() is inconsistent #69

Open flockonus opened 7 years ago

flockonus commented 7 years ago

Summary

The signature for waitForCondition is inconsistent between params timeout & milliSeconds so idk which is which

flockonus commented 7 years ago

It seems like the the second is the pooling interval

madhavajay commented 7 years ago

I can't get it to work as expected. Can I get an example of checking say how many elements are on the page like... $('.loading_divs').length == 0. I assume that a promise is required but it doesn't really go into detail or show any good examples and I tried reading the code but I can't seem to get it to respond the way I expect it to, its really confusing.

iszlailorand commented 7 years ago

Can I somehow use waitForAjaxCompleted command to use a condition for non jQuery Ajax calls, I don't have jQuery on the project. Thank for the answer.