mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

Pinny - Specify target container for Pinny #41

Closed donnielrt closed 10 years ago

donnielrt commented 10 years ago

Pinny will now be added to the target specified in options, instead of directly to body. This is to account for situations where appending to body won't work. For example, with ASP.Net sites, controls within Pinny won't interact with the master form.

Affected projects: Chefs Catalog

Status: Opened for visibility Reviewers: @kpeatt @scalvert @tedtate

kpeatt commented 10 years ago

@scalvert You mentioned this probably shouldn't use the term target.

kpeatt commented 10 years ago

@donnielrt You'll need to update the documentation to include information on this before we merge this.

donnielrt commented 10 years ago

@kpeatt added docs

scalvert commented 10 years ago

I added the velocity upgrade to this branch. Let's get this merged!

scalvert commented 10 years ago

@donnielrt can we write a unit test for the appendTo functionality?

donnielrt commented 10 years ago

@scalvert tests added!

scalvert commented 10 years ago

:+1: