search

mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

General android specific fixes #45

Closed wizardlyhel closed 10 years ago

wizardlyhel commented 10 years ago
  1. When pinny have form inputs, we need to disable all other input fields so that the prev/next toggle on keyboard cannot navigate to them.
  2. Give the pinny body wrapper a state when pinny is open.

Android 4.0 have an known issue where you can trigger tap highlight on elements behinds a position fixed element.

With this, we can apply android tap highlight fix only when pinny is open.

wizardlyhel commented 10 years ago

Reviewer: @kpeatt @scalvert

kpeatt commented 10 years ago

Thanks Hel!

We've got an input form switching fix in the #42 PR. I'll compare these and see which is better.

@scalvert and I are discussing the body wrapper today so we'll make sure these changes make it in to the discussion.

I like the addition of a pinny--is-open class when the Pinny is open. I think we can add that to html and then potentially have tap-highlighting turned off on body-wrapper when that's on.

wizardlyhel commented 10 years ago

Reviewer: @kpeatt @scalvert

wizardlyhel commented 10 years ago

@scalvert The reason I had it there is because that particular string is used 7 times in the js. It would save some bytes during minifying. If that particular json is not the appropriate place to be, is there another common place where we can store this then? or should I just define a variable for it?

scalvert commented 10 years ago

I'm going to close this issue in favour of the fixes we already have in place.