search

mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

1.0 RTM #47

Closed scalvert closed 10 years ago

scalvert commented 10 years ago

Updated pinny with structure changes, in addition to the addition of some tests.

Status: Ready to merge

Reviewers: @kpeatt @tedtate @donnielrt

Changes

kpeatt commented 10 years ago

@scalvert We should see about adding #45 and #46 to this before we RTM.

kpeatt commented 10 years ago

Tested and working on iOS5.1-8.1 as well as Android 4.3 Browser. Haven't tested as working on Android Chrome yet or other Android Browsers. This is looking really good.

tedtate commented 10 years ago

Seems like we are blocked here waiting on some more device testing. Lets get a checklist of what remains to be tested so we can get this thing released into the wild.

@scalvert @kpeatt @mobify-derrick missing anything?

kpeatt commented 10 years ago

Android 2.3 doesn't work. But we didn't target it for support.

kpeatt commented 10 years ago

Looks like we're ready to roll. @scalvert @donnielrt @tedtate.

There are some input-related issues that @Helen-Mobify has found that we'll want to prioritize for Post-1.0. But I think this is ready.

scalvert commented 10 years ago

OK, there's also some other things I need to change in here.

I want to incorporate Helen's android fixes into this release, but I want to extract all the device sniffing code. I've written a library to do that. Let's chat about this quickly.

kpeatt commented 10 years ago

I'm worried that we'll keep finding things to push this off. How comfortable are you with getting 1.0 out and having these things added post-release? They're both backward compatible changes.

donnielrt commented 10 years ago

I agree with @kpeatt, I think we should do this post 1.0 if this is a backwards-compatible change.