search

mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

Header and footer should be able to be passed as a template or element #5

Closed kpeatt closed 10 years ago

kpeatt commented 10 years ago

Instead of passing in title and closeText and building them automatically, people should be able to pass in an HTML block to use as the header. This should work for the footer as well.

scalvert commented 10 years ago

In the interest of consistency, I feel like we should drop title and closeText in favour of using header. The reason for this is we have footer already, and header is a sensible compliment to that. We're aiming for a predicable API, and this goes to that.

kpeatt commented 10 years ago

Sounds good to me

kpeatt commented 10 years ago

@scalvert Saw a commit for this. Is this fixed?

scalvert commented 10 years ago

Fixed by f5e98652682eb0b4f6027a6a37c1cd74dafa3120