Points to the updated lockup.js

mobify / pinny

A mobile-first content fly-in UI plugin

MIT License

23 stars 4 forks source link

Points to the updated lockup.js #50

Closed hora closed 10 years ago

hora commented 10 years ago

Status: Opened for visibility Reviewers: @scalvert

Changes

I've added a fix for wrapInner to lockup.js, this is pointing pinny to use that PR

kpeatt commented 10 years ago

:+1:

highruned commented 10 years ago

Seems a bit strange to change the endpoint to a branch rather than release a new fix version for lockup.

kpeatt commented 10 years ago

@ericmuyser I agreed — apparently this is just for testing right now and pre-merge this will be updated to point at the lockup update. I get the idea although I think maybe this should be marked as 'Not ready to merge'

scalvert commented 10 years ago

We do this all the time in product PRs. It's a way to segregate the changes in order to test drive. Once tested, we bump to a real version.

highruned commented 10 years ago

@scalvert @kpeatt I see! Good to know, thanks!