mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

Initializing Pinny with custom structure prevents scrolling inside `pinny__content` #57

Closed marlowpayne closed 9 years ago

marlowpayne commented 9 years ago

Steps:

  1. Set up Pinny markup container to have pinny__header, pinny__content, and pinny__footer defined. e.g.
<div class="c-pinny">
    <div class="pinny__header">
        Pinny Header
    </div>

    <div class="pinny__content">
        Pinny Content
    </div>

    <div class="pinny__footer">
        Pinny Footer
    </div>
</div> 
  1. Initialize Pinny with structure set false.
var $pinny = $('.c-pinny');
$pinny.pinny({
    structure: false
});
  1. Attempt to scroll Pinny's content

Result: Pinny's content does not scroll

Expected: Pinny's content scrolls after being initialized with custom header, content, and footer markup

marlowpayne commented 9 years ago

Closing this issue. Was missing class pinny__wrapper on wrapping container and class pinny--is-scrollable on pinny__content.