#48 - Form inputs are scrolled to incorrect position on iOS7 and under

[wizardlyhel]

When pinny is open and there are form elements in it, the pinny will scroll to the top when any input is focused.

Status: Opened for visibility

Reviewers: @scalvert @kpeatt Issue: https://github.com/mobify/pinny/issues/48

Changes

• We scroll to the active element using Velocity after the bounce fix is performed
• If the active element has the attribute positionParent in data, Velocity will scroll to this element instead

  Notes

• positionParent is introduced because if the active element's parent has the css declaration 'position: relative', then the active element will return the incorrect value for Velocity to scroll to.

[wizardlyhel]

@scalvert I pushed up all the adjustments that we agreed on.

[scalvert]

@Helen-Mobify dropped a few more comments in there!

[wizardlyhel]

@scalvert Pushed the code changes

[wizardlyhel]

@scalvert Changed the way I implement the scrollTarget parent.

[wizardlyhel]

@scalvert I moved the scroll target into its own function. I figure out why it's not working on pinny example. The lockup is still using the old 1.0.0 release of dist/lockup.js. I tried to blow away the lockup bower folder and it still didn't pull in the one on lockup-master. I'll look at it tomorrow.

[wizardlyhel]

It's my computer doing weird things with bower. Ignore me...

[kpeatt]

@Helen-Mobify bower cache clean will help with that. Bower is kind of a jerk.