Fix 63: Pinny gets distorted when the soft keyboard is shown after orientationchange

[hcstephencheung]

Status: Opened for visibility JIRA: https://mobify.atlassian.net/browse/CSOPS-1049 Reviewers: @scalvert @Helen-Mobify

Changes

• added _blurOnOrientationChange function to blur pinny inputs on orientation change.

  Notes

• Fix for this issue: https://github.com/mobify/pinny/issues/63

[hcstephencheung]

@scalvert @Helen-Mobify @ericmuyser Please review.

[hcstephencheung]

@scalvert @Helen-Mobify @ericmuyser Please review.

• @Helen-Mobify I think Eric was saying there's no need to check if element is input because calling .blur() on non-input elements doesn't cause an issue.
• When I call orientationchange, "this" is scoped to the window, so I can't use this._activeElement. I can create a _this outside of the eventHandler if we prefer to call activeElement using our own method.
• Removed the $pinny reference.

[wizardlyhel]

@hcstephencheung you can save the reference to 'this' before the orientationchange function

[hcstephencheung]

@Helen-Mobify Done. @scalvert @ericmuyser

[hcstephencheung]

@Helen-Mobify : thanks, changed _this to plugin @scalvert : I made the util function _isWithin. Let me know if you want it to return something else other than just true or false. (maybe just return the length?)

[kpeatt]

This seems good — should we make a test for it?

[scalvert]

@kpeatt good to go!

[scalvert]

To reply to your comment re: testing, I don't think we can devise a decent test for this. So no?