search

mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

updated readme dependencies #86

Closed dennislzf closed 9 years ago

dennislzf commented 9 years ago

Fixed readme documentation where vital components of pinny were not referenced in require file

Issue: resolve #85

Reviewers: @donnielrt @vmarta

Changes

donnielrt commented 9 years ago

Looping in @fractaltheory

donnielrt commented 9 years ago

Whoops, pressed the wrong button!

fractaltheory commented 9 years ago

When I try to use Pinny, I'm missing a reference to event-polyfill, so we should add that to the README. See #80

dennislzf commented 9 years ago

We should probably fix that file name too sometime soon.

fractaltheory commented 9 years ago

Well, if you're already working on this PR ... :wink:

wizardlyhel commented 9 years ago

Is this done? Can we merge this?

dennislzf commented 9 years ago

Yes I believe it is good to go

fractaltheory commented 9 years ago

@dennislzf could you ensure we have a package.json/bower.json version bump, CHANGELOG update, and github release please (if you have permissions)?

And actually, now that I think about this - this is a breaking change. Users will need to update their require config or their project will fail to build. Might want to specifically call that out in the changelog and release description.