Closed jeffkamo closed 9 years ago
Otherwise +1 -1 I’m just not sure right now.
Haha @ry5n.
Do we want to totally cancel this then? If so I can close this and make a PR to remove the placeholder class that was previously merged on visibility.
Sorry, no, don’t cancel this yet. The visually-hidden placeholder is genuinely useful. Maybe a few others too, like all-caps. But @extend %float-start
which sets float: left
seems of questionable value (except for RTL sites maybe). Widths definitely: @extend %u-width-1of2
instead of width: 50%
seems like kindof a facepalm. Certainly if we go forward I’d rather just write out flex: initial
I think with a top-level comment.
@ry5n This is blocking us on releasing 1.0 right now. Have any additional thoughts on this?
For these utils in particular, I don’t think there’s an actual use case for placeholders. However, the argument would be for consistency: if we do some utils as placeholders then we should do them all
. The implementation here bugs me only aesthetically (I would rather just see flex: initial
added to each declaration) but I won’t block merging this, and I support it if you are both +1.
@ry5n Let's add flex initial to each declaration. It fixes a concern @jeffkamo and I had with discoverability too.
OK
@ry5n Okay I think we're GtM on this.
+1. (And sorry for being so cranky)
Were you cranky?
However, the argument would be for consistency: if we do some utils as placeholders then we should do them all.
@ry5n @jeffkamo I don't think that in this case we benefit from consistency. If we're not supposed to use some %extends
maybe it's worth not to have it on the elements that don't need it?
@nastiatikk are you proposing that some be removed? Maybe it's better to create an issue to discuss this in rather than in this old PR.
Status: Opened for Review Reviewers: @kpeatt @ry5n @avelinet @cole-sanderson @mlworks @nastiatikk JIRA: CSOPS-954
Changes
$u-width-1of3
) to all utilities