Grid Component - fix for 2 col grid bug on 32bit iOS devices

mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.

MIT License

4 stars 0 forks source link

Grid Component - fix for 2 col grid bug on 32bit iOS devices #120

Closed avelinet closed 9 years ago

avelinet commented 9 years ago

Fix for 2 column grids not displaying properly on 32bit iOS devices

Status: Ready to merge

Reviewers: @jeffkamo @ry5n @nastiatikk @cole-sanderson @mlworks @kpeatt

Changes

changed nth-child to nth-of-type

ry5n commented 9 years ago

Could this affect grids that use different elements as grid spans? Should we leave nth-child and add nth-of-type?

nastiatikk commented 9 years ago

This tweak seems fair, but I'd test it in case if nth-child and nth-of-type can conflict each other.

I have tried to test it on AnnTaylor project where we had this bug on PLP but I couldn't reproduce it anymore, it works fine with both nth-child and nth-of-type.

kpeatt commented 9 years ago

I think this is a good initial fix and we can address Ryan's edge case at a later date.