mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.
MIT License
4 stars 0 forks source link

iOS6 icon component fix #124

Closed nastiatikk closed 9 years ago

nastiatikk commented 9 years ago

iOS6 fix when we have several different icons in a row but device shows them all identical

Status: Ready to review

Reviewers: @cole-sanderson @jeffkamo @avelinet @ry5n @mlworks @kpeatt

screenshot 2015-02-12 17 44 26

kpeatt commented 9 years ago

How does this fix work?

nastiatikk commented 9 years ago

Magically. It's seems to be iOS6 unexplainable bug that is fixed with min-width property with no logic (at least I can't see any). Min-width can be any px (1px, 0px, 20px, etc.)

I've updated top comment with the screen

nastiatikk commented 9 years ago

Two screens from icon stencil component (with and without min-width)

1 2

kpeatt commented 9 years ago

What the :hankey:.

Nice find.

jeffkamo commented 9 years ago

As a future fix, we may want to set to min-width: 0, which apparantely also works. Low priority thing though.

kpeatt commented 9 years ago

I'd make a PR for that so we don't lose that. Good enhancement.