Components clean up - Githubissues

nastiatikk commented 9 years ago

Status: Ready for Review Reviewers: @avelinet @jeffkamo @ry5n @mlworks @cole-sanderson @kpeatt @yourpalsonja

Changes

Example code and attribution were removed from scss (with a control that they present in the component readme.md file)
Selectors order slightly changed in couple components to Component, Component pseudo-element, Component modifier, Child, Child pseudo-element, Child-modifier, Combined modifiers
Scss files follow our code-style
"Notes: " title was removed from scss files
_ was removed from dust files that had it
{!} Component desctiprion {!} was removed from dust files

Hopefully now Stencil will look consistent and clear.

ry5n commented 9 years ago

Did a first pass, changes look good.

jeffkamo commented 9 years ago

Looks pretty good! +1

ry5n commented 9 years ago

Yup, agree.

ry5n commented 9 years ago

@nastiatikk Leaving this to you as per your comment in chat.

jeffkamo commented 9 years ago

Indeed, feel free to resolve any conflicts and get this PR merged :)