mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.
MIT License
4 stars 0 forks source link

Improve directory structure #23

Closed ry5n closed 10 years ago

ry5n commented 10 years ago

Improve directory structure organization. Fixes #20.

Status: Opened for visibility Reviewers: @kpeatt @jeffkamo

Notes

ry5n commented 10 years ago

The only thing I’m not sure of here is the flatter directory structure, where I have e.g. dist/components-arrange instead of dist/components/arrange. The import is not as clear to write, no shorter, and the directory list contains extra visual noise:

dist/
    components-align
    components-arrange
    components-button
    components-grid
    components-media
    components-ratio
    components-stack
    components-test
    utils-dimension
    utils-text
    utils-visibility

vs.

dist/
    components/
        align
        arrange
        button
        grid
        media
        ratio
        stack
        test
    utils/
        dimension
        text
        visibility

Thoughts?

kpeatt commented 10 years ago

I like the latter. I'm all for structure in directories vs in file names where possible.

kpeatt commented 10 years ago

@ry5n — can you run this against SCSS lint as well?

ry5n commented 10 years ago

I created #24 for linting.

ry5n commented 10 years ago

Pushed up a new commit that restores the deeper directory structure.

kpeatt commented 10 years ago

:+1:

ry5n commented 10 years ago

Took the liberty of renaming test/tests/ to tests/visual/. When I get PhantomCSS integration done, we can add tests/regression/ for running regression tests against the visual tests.

kpeatt commented 10 years ago

You're a golden god. I'll take a look at this either this weekend or early next week.

kpeatt commented 10 years ago

A++ would merge again.