Closed ry5n closed 10 years ago
The only thing I’m not sure of here is the flatter directory structure, where I have e.g. dist/components-arrange instead of dist/components/arrange. The import is not as clear to write, no shorter, and the directory list contains extra visual noise:
dist/
components-align
components-arrange
components-button
components-grid
components-media
components-ratio
components-stack
components-test
utils-dimension
utils-text
utils-visibility
vs.
dist/
components/
align
arrange
button
grid
media
ratio
stack
test
utils/
dimension
text
visibility
Thoughts?
I like the latter. I'm all for structure in directories vs in file names where possible.
@ry5n — can you run this against SCSS lint as well?
I created #24 for linting.
Pushed up a new commit that restores the deeper directory structure.
:+1:
Took the liberty of renaming test/tests/
to tests/visual/
. When I get PhantomCSS integration done, we can add tests/regression/
for running regression tests against the visual tests.
You're a golden god. I'll take a look at this either this weekend or early next week.
A++ would merge again.
Improve directory structure organization. Fixes #20.
Status: Opened for visibility Reviewers: @kpeatt @jeffkamo
Notes
Changes