Lint and Comb every Stencil component

[kpeatt]

Status: Opened for visibility Reviewers: @jeffkamo @ry5n

Changes

• Added SCSS Lint and CSSComb rules to the root of the directory.
• Linted every file and subsequently ran comb. Then did a manual pass for readability in some places. This means Stencil does not 100% match our linting rules but I think it's okay to break from the norm here and there. For example, arrange is much more readable with each modifier being one line.

  Notes

• The version of CSSComb I used for this is still in development. The linter is ready to use. Should probably get a question written up on how to use it.
• This addresses https://github.com/mobify/stencil/issues/24
• This repo is totally ready for the weekend:

[ry5n]

I’m surprised there are so few code changes needed. All the ones in the diff look good.

The deal-breaker for me here is that we shouldn’t be adding lint and comb configs to project repos: they should live in the mobify-code-style repo and Stencil should depend on them via npm. Consistency is hard to cultivate and having multiple configs that can get out of sync is something we should avoid.

[kpeatt]

@ry5n Ah, good idea. I'll get those out and see how our npm module works.

[ry5n]

Probably should be a devDependency in package.json. We should add a grunt task for each linter.