mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.
MIT License
4 stars 0 forks source link

Improve browser support for dimension utils used with flexbox. #55

Closed ry5n closed 9 years ago

ry5n commented 10 years ago

When dimension utils are used on flex items, we need to ensure that their flex-* properties (grow, shrink, basis) are reset in order for the width specified by the util to take effect. Previously this was set with flex: none but this has issues in some older flexbox implementations. Using flex: initial solves the issue.

Status: Ready to merge

Reviewers: @kpeatt, @jeffkamo Ticket: fixes #50 Linked PRs: N/A

Changes

ry5n commented 10 years ago

Hmmm… not able to reproduce this right away, and looking back at at WHSmith we don’t have all the details on why this was necessary. I guess we need a test case before we should make this change.

kpeatt commented 10 years ago

@ry5n I'm not too concerned if it doesn't cause issues on the newer ones and seems to fix older ones but a test case would be nice.