mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.
MIT License
4 stars 0 forks source link

Revamp buggy Align component #58

Closed ry5n closed 10 years ago

ry5n commented 10 years ago

Remove unsupported Align component features, support horizontal alignments and update code style. Incorporates the changes in #54. This makes the component pretty small; we should consider deprecating it in favour of direct use of flexbox.

Status: Ready to merge

Reviewers: @kpeatt @jeffkamo Ticket: Fixes #45

Changes

kpeatt commented 10 years ago

@ry5n I think lots of these components have really simple direct uses but the idea is to avoid rewriting stuff often. This looks good to me.

ry5n commented 10 years ago

OK, cool. @kpeatt @jeffkamo can one of you check the tests for this and merge if it all checks out?

kpeatt commented 10 years ago

@ry5n Might get a chance to poke at this today otherwise it's my first priority on Monday.