search

mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.
MIT License
4 stars 0 forks source link

Component arrange justify content #62

Closed nastiatikk closed 9 years ago

ry5n commented 10 years ago

Definitely this component could cover more of what flexbox offers. In the longer term we might want to think more about what it should/shouldn’t do and whether it should be refactored to take things like justify into account.

In the short term, the modifier name proposed here is a bit long. Maybe just c--justify-between or c-justify-full. Might need to add c--justify-around aka c--justify as well for completeness. Also need to add tests for this modifier(s).

kpeatt commented 10 years ago

@nastiatikk Agreed with what @ry5n laid out above. Let's get those done and otherwise this seems good.

nastiatikk commented 10 years ago

Ok, @ry5n @kpeatt! Modifiers added, test file updated

avelinet commented 10 years ago

@nastiatikk I think the test descriptions could be more detailed. There are 5 variations but the descriptions are the same.

jeffkamo commented 9 years ago

Looks good, @nastiatikk! +1

ry5n commented 9 years ago

Belated +1. Good work @nastiatikk !