Clear none as a fix to iOS8 iPhone5 floats issue

mobify / stencil

DEPRECIATED - The latest Stencil development is currently taking place in the Adaptive.js repo.

MIT License

4 stars 0 forks source link

Clear none as a fix to iOS8 iPhone5 floats issue #78

Closed nastiatikk closed 9 years ago

nastiatikk commented 10 years ago

I met this issue only on iOS8 iPhone5 in all places where grid was used on Carnival. iPhone6 iOS8 works fine with this component.

Probably we don't need to make it as a component fix, but should explore the issue.

nastiatikk commented 10 years ago

Probably it's a rendering issue, when you rotate device it builds properly

nastiatikk commented 10 years ago

Updates:

This is not :nth-child issue, changing it to :nth-of-type doesn't fix it
Isolating grid elements hasn't solved this issue as well
Test html works correct on this device, so this is something project specific…
At the same time having clear: none doesn't brake anything but also fixes device and project specific issue

jeffkamo commented 10 years ago

I feel that we should only include clear: none as a pre-emptive fix is if the problem is serious enough and common enough that we'll wind up doing it often anyway.

@nastiatikk were you able to pinpoint the exact problem in your project?

nastiatikk commented 10 years ago

@jeffkamo No, and I found another weirdo - clear: none doesn't fix the issue if it's applied on the global level (like inside Grid component). But it fixes the issue when applied to each grid component individually (in the footer, in the list, in any other component where grid was applied).

ry5n commented 9 years ago

@nastiatikk Sounds like this is a project-specific issue. I’m also not clear if this change actually fixed the issue for you – it sounds like actually it did not? I’d still like to understand the problem in any case.

jeffkamo commented 9 years ago

Closing since this doesn't fix the problem.