search

mobify / vellum

Default project styles for a mobile-first AdaptiveJS build.
MIT License
5 stars 0 forks source link

width: 100% to button and [type="submit"] #60

Closed cole-sanderson closed 9 years ago

cole-sanderson commented 9 years ago

Do we need to set button and [type="submit"]width to 100%? There is width issue with button component from Vellum elements. I had to add width: auto to button component to override 100% width from Vellum.

https://github.com/mobify/stencil/edit/add-vellum/dist/components/button/_button.scss?pr=/mobify/stencil/pull/106

kpeatt commented 9 years ago

There is a disconnect between what we say is a default button in Vellum and what we say in Stencil. We should bring these in line.

jeffkamo commented 9 years ago

I wouldn't mind removing that width: 100% declaration. Was there a reason we put that there in the first place?

kpeatt commented 9 years ago

I think it was a hold over from previous default styles. I'm okay with removing it.

cole-sanderson commented 9 years ago

PR: https://github.com/mobify/vellum/pull/62