search

mobify / vellum

Default project styles for a mobile-first AdaptiveJS build.
MIT License
5 stars 0 forks source link

Use $form-border-radius #61

Closed avelinet closed 9 years ago

avelinet commented 9 years ago

Status: Ready to merge

Reviewers: @kpeatt @jeffkamo

jeffkamo commented 9 years ago

Thanks for fixing this, Aveline!

Although I think we should probably start using the variable naming convention that we use in stencil. That pattern is... $filename__{modifier-}variable-name (see an example here).

So in this case, we'd want something like $form__border-color, $form__active-border-color, etc.

avelinet commented 9 years ago

Good idea. I'll update all them vars.

kpeatt commented 9 years ago

@avelinet Not sure about forms versus form but otherwise looks good.

jeffkamo commented 9 years ago

I was thinking that, because there are no real class names to go off of, these variables should probably match the filename itself.

kpeatt commented 9 years ago

Works for me.