mobify / vellum

Default project styles for a mobile-first AdaptiveJS build.
MIT License
5 stars 0 forks source link

Prepare Vellum to work with Stencil #90

Closed ry5n closed 9 years ago

ry5n commented 9 years ago

Previously #88; re-creating to change target branch as per #89.

For consistency Stencil components will all depend on a minimal set of shared variables. This PR ensures that Vellum plays nice with this set, and removes some unnecessary complexity from the existing variables file. Closes #72.

Status: Ready to merge

Reviewers: @tedtate @jeffkamo @fractaltheory Ticket: RTM-128/CSOPS-1256 Linked PRs: compare with https://github.com/mobify/stencil-variables/blob/master/variables.scss

Feedback

Made variable naming guidelines at the top of the file way more concise.

Removed or renamed:

Added:

jeffkamo commented 9 years ago

+1