Test page fix

[nastiatikk]

Status: Ready for Review Reviewers: @ry5n @jeffkamo @avelinet @yourpalsonja @cole-sanderson @mlworks

Changes

Due to the regression described in https://github.com/mobify/vellum/issues/82#issuecomment-117310613 index.html content was replaced with index.html content from the commit ID https://github.com/mobify/vellum/commit/5855149045b171738f57bec918a6a572a8330058 (the latest correct state of this file)

Todos:

• [x] Designer +1 @jeffkamo
• [x] Designer +1 @ry5n

[ry5n]

This is open to anyone to review as well – if folks are free.

[jeffkamo]

Hmm, I could have sworn we had documentation on the proper use of html headings, but can't seem to find it in either confluence or the mobify-code-style... am I crazy?

Anyway, as mentioned by Steve Faulkner in a blog post, browser vendors have not implemented HTML5 document outline. So, section elements like section, article, etc. have no impact on the document outline. As such, only one h1 should be used on a page to ensure backwards compatibility.

All of the <h1> elements inside <section>s should just be <h2> tags, then the following <h2> tags should be <h3> tags, and so on.

Basically, assume the HTML5 document outline does not exist and build your headings accordingly.

[ry5n]

Yup

[nastiatikk]

As a reminder here is a highlighted note from w3.org

There are currently no known implementations of the outline algorithm in graphical browsers or assistive technology user agents, although the algorithm is implemented in other software such as conformance checkers. Therefore the outline algorithm cannot be relied upon to convey document structure to users. Authors are advised to use heading rank (h1-h6) to convey document structure.

[jeffkamo]

Gave the change a quick look through. Markup looks good! +1

[ry5n]

Looks good, but we should merge into the pre-release branch in future.

[nastiatikk]

Thanks, will remember!

[jeffkamo]

this time I forgot about pre-release (d'oh)