mobile-dev-inc / action-maestro-cloud

19 stars 14 forks source link

How to select a different iPhone Simulator model in CI Action #40

Open kieranmccwayleadr opened 4 months ago

kieranmccwayleadr commented 4 months ago

We are using the Github Action to deploy a built version of our app along with the flows. The flows were created with iPhone 15 Max in mind and while running locally works, I found the cloud version defaults to iPhone 11. How can we tell the cloud action that we want to use a iPhone 15 version?

kieranmccwayleadr commented 4 months ago

@axelniklasson Just wondering if this is doable? If not we need to change how we do our testing. So some info would be appreciated. Thanks

axelniklasson commented 4 months ago

@kieranmccwayleadr at the moment you can only select between iOS 15, 16 and 17 and not change to another device model (eg iPhone 15)

kieranmccwayleadr commented 4 months ago

@axelniklasson do ye see that changing? For instance, when using the redefined onTap for coordinates, it's not going to work?

axelniklasson commented 4 months ago

@axelniklasson do ye see that changing?

We're not planning any changes regarding selecting other device models at the moment.

For instance, when using the redefined onTap for coordinates, it's not going to work?

Hm, I'm afraid I don't really understand what you mean here?

kieranmccwayleadr commented 4 months ago

That's a shame you aren't thinking about other devices.

As for the predefined onTap method, if you are working on a iPhone 15 to work through your testing flows, and some widgets don't work fully with the Semantics wrapper, you need to use the coordinates for onTap to tap the button. Especially for some close buttons too in modals etc.

bartekpacia commented 1 month ago

Somewhat related: https://github.com/mobile-dev-inc/maestro/issues/1897